Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add power/energy sensor for Matter draft electrical measurement cluster #132920

Merged
merged 14 commits into from
Jan 28, 2025
Merged

Add power/energy sensor for Matter draft electrical measurement cluster #132920

merged 14 commits into from
Jan 28, 2025

Conversation

dext0r
Copy link
Contributor

@dext0r dext0r commented Dec 11, 2024 •
edited
Loading

Breaking change

Proposed change

Yandex Smart Socket (YNDX-00540) use ElectricalMeasurement cluster that was in draft Matter specification but not made in 1.0 spec. It was finally removed in v1.4 branch of Matter SDK (see project-chip/connectedhomeip#35583)

Depends on #132502

Screenshot 2024-12-11 at 13 43 22 Screenshot 2024-12-11 at 13 43 32

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dext0r dext0r mentioned this pull request Dec 11, 2024
Merged
@dext0r dext0r marked this pull request as ready for review January 9, 2025 20:09
@dext0r dext0r requested a review from a team as a code owner January 9, 2025 20:09
@dext0r
Copy link
Contributor Author

dext0r commented Jan 23, 2025

@marcelveldt Could you please take a look?

@marcelveldt
Copy link
Member

marcelveldt commented Jan 24, 2025 •
edited
Loading

I'll come back to you on this one asap. Need to discuss if we want to merge in something that was never supposed to be used. Maybe set a deprecation date. Point is that you want a nudge towards manufacturers to just update their devices to 1.3 - this draft cluster was never supposed to be used in devices.

Had a quick talk about this and we're just going to merge this as-is, there is very little risk to it or reason to deprecate it other than you just shouldn't use any matter 1.0 devices but that is for other reasons.

@marcelveldt marcelveldt changed the title Add Matter power/energy sensor for draft electrical measurement cluster (YNDX-00540 Socket) Add power/energy sensor for Matter draft electrical measurement cluster Jan 25, 2025
marcelveldt
marcelveldt approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dext0r !

@marcelveldt
Copy link
Member

@dext0r tests seem to be failing, can you have a look?

@dext0r
Copy link
Contributor Author

dext0r commented Jan 25, 2025

Point is that you want a nudge towards manufacturers to just update their devices to 1.3 - this draft cluster was never supposed to be used in devices.

I informed the manufacturer about use of draft clusters. But I don't know if they plan to release a new firmware. I will submit a pull request when/if it happens.

@dext0r tests seem to be failing, can you have a look?

Tests was fixed, thanks.

marcelveldt
marcelveldt approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dext0r !

@marcelveldt marcelveldt merged commit 0cd7aff into home-assistant:dev Jan 28, 2025
32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcelveldt marcelveldt marcelveldt approved these changes

Assignees
No one assigned
Labels
cla-signed has-tests integration: matter new-feature Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dext0r @marcelveldt